Mar 02, 2016
Yosh M wrote
Big issue: The tax rules in Administration > Taxes > Tax Rules is not hiding tax rules that are deleted ("deleted" column in db = 1). When opening a new product the "Tax" select does not hide them either, it shows all rules, no matter if deleted or not.
This is causing many headaches lately because an employee opened many new products and assigned a tax rule that was deleted and so in the backoffice the products say the have no tax assigned and on the frontend tax is not calculated.
Please fix a.s.a.p. It would also come in handy to be able to find which products have a specific tax rule assigned to fix issues like this one.
This is causing many headaches lately because an employee opened many new products and assigned a tax rule that was deleted and so in the backoffice the products say the have no tax assigned and on the frontend tax is not calculated.
Please fix a.s.a.p. It would also come in handy to be able to find which products have a specific tax rule assigned to fix issues like this one.
Under review
1 vote
Vote
Reply
26 Answers
Mar 02, 2016
Yosh M
wrote
So you can compare with above screenshots, this is the db screenshot.
Mar 02, 2016
Alex Pryshlivskiy
agent
wrote
Thanks for comment, Yosh,
Give us some time - we are going to reproduce your issue.
Give us some time - we are going to reproduce your issue.
Mar 04, 2016
Yosh M
wrote
Were you able to reproduce?
Mar 04, 2016
Alex Pryshlivskiy
agent
wrote
WE have tried to remove Tax rules from PrestaShop 1.6.1.1 , ver. 1.6.1.4
deleted = 1 was not reproduced in our cases.
Video - http://screencast.com/t/PYrdx96NYdCx
Deleting without enable option -
There is no 1 for column - "deleted" - watch video - http://screencast.com/t/y4HVEegu3h4
So PrestaShop remove record without =1
Could you provide your video with such issue ?
P.S. 2 - Do you have custom module for Taxes? what version of PrestaShop do you have ?
deleted = 1 was not reproduced in our cases.
Video - http://screencast.com/t/PYrdx96NYdCx
Deleting without enable option -
There is no 1 for column - "deleted" - watch video - http://screencast.com/t/y4HVEegu3h4
So PrestaShop remove record without =1
Could you provide your video with such issue ?
P.S. 2 - Do you have custom module for Taxes? what version of PrestaShop do you have ?
Mar 06, 2016
Yosh M
wrote
Hello,
The deleted field does not turn to 1 when simply deleting a rule, it happens on update (only some situations depending on products that have current tax rule that is being updated). You can see in the core TaxRulesGroup class (attached). However, this situation should be checked by PS Manager, if there is a deleted field and it is 1, then I shouldn't be able to assign this tax rule to a product, just like in the BO.
I don't have custom module for taxes.
The deleted field does not turn to 1 when simply deleting a rule, it happens on update (only some situations depending on products that have current tax rule that is being updated). You can see in the core TaxRulesGroup class (attached). However, this situation should be checked by PS Manager, if there is a deleted field and it is 1, then I shouldn't be able to assign this tax rule to a product, just like in the BO.
I don't have custom module for taxes.
Mar 07, 2016
Alex Pryshlivskiy
agent
wrote
Good morning Yosh,
It seems, that such situation will be occurred according to this scheme (I'm not sure - please correct me if I wrong),:
1. We need to have a customer with tax rules (for example - Tax-rule- AZ)
2. To create order with this customer
3. Try to remove Tax-rule-AZ from PrestaShop
4. In this case, field Deleted should be changed to 1
Right now I can't catch this logics ... please let me know if you know how to do this.
P.S. From my side - I'll add to list of task - don't show Tax Rules where field "deleted" = 1
It seems, that such situation will be occurred according to this scheme (I'm not sure - please correct me if I wrong),:
1. We need to have a customer with tax rules (for example - Tax-rule- AZ)
2. To create order with this customer
3. Try to remove Tax-rule-AZ from PrestaShop
4. In this case, field Deleted should be changed to 1
Right now I can't catch this logics ... please let me know if you know how to do this.
P.S. From my side - I'll add to list of task - don't show Tax Rules where field "deleted" = 1
Mar 07, 2016
Yosh M
wrote
Yes, those sound like the correct steps.
I guess you just have to check when deleting/modifying a tax rule if there is any order with products that have that tax rule (tax rules are attached to products and countries/states, not to customers). If the query returns true, then deleted = 1. From this moment this tax rule should not show up as available anywhere.
I guess you just have to check when deleting/modifying a tax rule if there is any order with products that have that tax rule (tax rules are attached to products and countries/states, not to customers). If the query returns true, then deleted = 1. From this moment this tax rule should not show up as available anywhere.
Mar 09, 2016
Alex Pryshlivskiy
agent
wrote
Sure, you are right.
I've added this task in the development list to fix this problem.
I going to include this task in the next Release.
I've added this task in the development list to fix this problem.
I going to include this task in the next Release.
Apr 21, 2016
Yosh M
wrote
the next version was released and this was not fixed :(
Apr 22, 2016
Alex Pryshlivskiy
agent
wrote
Good morning Yosh!
Thanks for update.
It was Advanced Stock Management dedicated Release.
So right now we are going to create new small fix release for last tasks.
I've contacted our QA department. - they still didn't reproduce step-by-step issue for this case.
Give me some time - they are working on it and let me know. I'll try to update your ticket soon.
Thanks for update.
It was Advanced Stock Management dedicated Release.
So right now we are going to create new small fix release for last tasks.
I've contacted our QA department. - they still didn't reproduce step-by-step issue for this case.
Give me some time - they are working on it and let me know. I'll try to update your ticket soon.
Apr 22, 2016
Alex Pryshlivskiy
agent
wrote
Small update....
This task was added in the current Release.
Estimated date - 26 May 2016
Roadmap for this Release with task list will be available soon - https://www.prestashopmanager.com/store-manager-for-prestashop-roadmap/
This task was added in the current Release.
Estimated date - 26 May 2016
Roadmap for this Release with task list will be available soon - https://www.prestashopmanager.com/store-manager-for-prestashop-roadmap/
Apr 27, 2016
System
wrote
Hello,
We haven't heard back from you for last 5 days, please confirm that all questions were answered and issues are resolved. In case you haven't received an answer, please check your spam folder or check the status of ticket online at:
https://support.emagicone.com
Maybe we are waiting for some information from your side? In this case please get back to us.
In case we haven't replied you back or in case of any misunderstanding, please reply to this mail with all details so we could proceed.
If you do not reply us back, the ticket will be automatically closed within 24 hours.
With kind regards,
The eMagicOne Administration Team
We haven't heard back from you for last 5 days, please confirm that all questions were answered and issues are resolved. In case you haven't received an answer, please check your spam folder or check the status of ticket online at:
https://support.emagicone.com
Maybe we are waiting for some information from your side? In this case please get back to us.
In case we haven't replied you back or in case of any misunderstanding, please reply to this mail with all details so we could proceed.
If you do not reply us back, the ticket will be automatically closed within 24 hours.
With kind regards,
The eMagicOne Administration Team
May 11, 2016
Yosh M
wrote
Nice to see this is fixed in last beta. Thanks.
May 11, 2016
Alex Pryshlivskiy
agent
wrote
Thanks for your comments and suggestion, Yosh!
Official Release will be available next week.
:-)
Official Release will be available next week.
:-)
Jun 11, 2016
Yosh M
wrote
Once again, I have to reopen this bug. It is not fully fixed.
When importing products with Tax field, instead of assigning active (not deleted) Tax group that matches name, it assigns first one, even if it is deleted and should not be used (these do not even show in BO). This causes headaches. Your QA department should notice this kind of issues before public releases... I feel like I find more bugs than you guys :(
When importing products with Tax field, instead of assigning active (not deleted) Tax group that matches name, it assigns first one, even if it is deleted and should not be used (these do not even show in BO). This causes headaches. Your QA department should notice this kind of issues before public releases... I feel like I find more bugs than you guys :(
Jun 13, 2016
Alex Pryshlivskiy
agent
wrote
Thanks, Yosh.
Your request is under review.
I"ll update status shortly after getting results.
Your request is under review.
I"ll update status shortly after getting results.
Jun 14, 2016
Alex Pryshlivskiy
agent
wrote
Good morning Yosh!
Our QA dep. couldn't reproduce this issue.
Give us more details, please.
Video screenshot will speed up testing, I guess.
Could you send me link to email?
Thanks in advance.
Our QA dep. couldn't reproduce this issue.
Give us more details, please.
Video screenshot will speed up testing, I guess.
Could you send me link to email?
Thanks in advance.
Jun 14, 2016
Yosh M
wrote
It is very simple to reproduce.
1) Have one tax rule group called "VAT 21%" for example, with field "deleted" = 1 in database
2) Have another tax rule group called exactly the same with field "deleted" = 0
3) id of 1) should be lower than 2). for example first tax group id=1, and second one id=2
4) Import a CSV with field "Tax" and values "VAT 21%"
5) tax rule group 2) should be assigned to product, since 1) is deleted , but the opposite happens (1) is assigned)
6) if you follow exact steps you should reproduce, if not I will make screencast but I don't have time now.
1) Have one tax rule group called "VAT 21%" for example, with field "deleted" = 1 in database
2) Have another tax rule group called exactly the same with field "deleted" = 0
3) id of 1) should be lower than 2). for example first tax group id=1, and second one id=2
4) Import a CSV with field "Tax" and values "VAT 21%"
5) tax rule group 2) should be assigned to product, since 1) is deleted , but the opposite happens (1) is assigned)
6) if you follow exact steps you should reproduce, if not I will make screencast but I don't have time now.
Jun 14, 2016
Yosh M
wrote
I tested several times and it happened each time.
Jun 14, 2016
Alex Pryshlivskiy
agent
wrote
Thanks for details.
Jun 20, 2016
Yosh M
wrote
where you able to reproduce?
Jun 20, 2016
Alex Pryshlivskiy
agent
wrote
Good day, Yosh!
Your comment was confirmed, thank you.
This task was added to our "To-do" list.
Your comment was confirmed, thank you.
This task was added to our "To-do" list.
Jul 11, 2016
Yosh M
wrote
why do you not fix these MAJOR bugs with a higher priority? I mean, importing 2000 products that get assigned a wrong tax group, then having to change them manually....
Jul 21, 2016
Alex Pryshlivskiy
agent
wrote
Hello, Yosh!
Just returned.
We'll change a status of this task to the Hight level.
Just returned.
We'll change a status of this task to the Hight level.
Jul 27, 2016
System
wrote
Hello,
We haven't heard back from you for last 5 days, please confirm that all questions were answered and issues are resolved. In case you haven't received an answer, please check your spam folder or check the status of ticket online at:
https://support.emagicone.com
Maybe we are waiting for some information from your side? In this case please get back to us.
In case we haven't replied you back or in case of any misunderstanding, please reply to this mail with all details so we could proceed.
If you do not reply us back, the ticket will be automatically closed within 24 hours.
With kind regards,
The eMagicOne Administration Team
We haven't heard back from you for last 5 days, please confirm that all questions were answered and issues are resolved. In case you haven't received an answer, please check your spam folder or check the status of ticket online at:
https://support.emagicone.com
Maybe we are waiting for some information from your side? In this case please get back to us.
In case we haven't replied you back or in case of any misunderstanding, please reply to this mail with all details so we could proceed.
If you do not reply us back, the ticket will be automatically closed within 24 hours.
With kind regards,
The eMagicOne Administration Team